[PATCH] D131593: [CMake] Update FindGPRC to use add_llvm_library

Tue Aug 16 08:58:40 PDT 2022

steven_wu added a comment.

In D131593#3725476 <https://reviews.llvm.org/D131593#3725476>, @sammccall wrote:

> Hi Steven,
>
> Sorry for missing this, I've been out on medical leave & vacation.
> I don't see any big problems here, the usage of add_clang_library seems to be mostly passthrough to add_llvm_library.

Thanks for looking! I pulled the trigger and didn't see anything broken from bots yet. If there are any downstream bots I don't have access that you seen broken, please let me know and I can help investigating.

> I'm not certain about all the platforms/build modes but agree that seeing if it breaks something is reasonable.
> That said, this sort of change can break somewhat obscure configurations and may need a fix/revert at some later point, which could be awkward if you have downstream dependencies but nothing in-tree to guarantee this works.
>
> (I'm curious what you plan to use grpc for, if that's public)

This is just a cleanup that I am preparing/experimenting with CAS integration. (See RFC: https://discourse.llvm.org/t/rfc-add-an-llvm-cas-library-and-experiment-with-fine-grained-caching-for-builds). I was playing with some solutions to integrate 3rd party CAS with the LLVM CAS interface we are proposing and want to use gRPC to connect with other CAS solutions as an option.

I currently have a PR open on Apple Github to do some experiments with GRPC CAS: https://github.com/apple/llvm-project/pull/5033. The plan is to upstream this GRPC protocol unless there are objections. There are some dependencies we need to upstream first before we can get there.

I will cleanup the option names that mentions `clangd` in a followup.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131593/new/

https://reviews.llvm.org/D131593