[PATCH] D131593: [CMake] Update FindGPRC to use add_llvm_library

[Sam McCall via Phabricator via llvm-commits]

sammccall added a comment.

Hi Steven,

Sorry for missing this, I've been out on medical leave & vacation.
I don't see any big problems here, the usage of add_clang_library seems to be mostly passthrough to add_llvm_library.

I'm not certain about all the platforms/build modes but agree that seeing if it breaks something is reasonable.
That said, this sort of change can break somewhat obscure configurations and may need a fix/revert at some later point, which could be awkward if you have downstream dependencies but nothing in-tree to guarantee this works.

(I'm curious what you plan to use grpc for, if that's public)



================
Comment at: llvm/cmake/modules/FindGRPC.cmake:1
 option(ENABLE_GRPC_REFLECTION "Link clangd-index-server to gRPC Reflection library" OFF)
 
----------------
There's a mention of clangd here that should probably be made more generic too


================
Comment at: llvm/cmake/modules/FindGRPC.cmake:45
   if (NOT GRPC_CPP_PLUGIN OR NOT PROTOC)
     message(FATAL_ERROR "gRPC C++ Plugin and Protoc must be on $PATH for Clangd remote index build.")
   endif()
----------------
another mention of clangd


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131593/new/

https://reviews.llvm.org/D131593