[PATCH] D131962: [RegisterInfoEmitter] Generate isConstantPhysReg(). NFCI

[Alexander Richardson via Phabricator via llvm-commits]

arichardson marked 2 inline comments as done.
arichardson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.td:227
 defm SGPR_NULL : SIRegLoHi16 <"null", 0>;
 defm SGPR_NULL_HI : SIRegLoHi16 <"", 0>;
+} // isConstant = true
----------------
jrtc27 wrote:
> This wasn't constant before
That's true, but since it's a subreg if SGPR_NULL64 I assumed it must be.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.td:242
 defm SRC_PRIVATE_LIMIT : SIRegLoHi16<"src_private_limit", 238>;
 defm SRC_POPS_EXITING_WAVE_ID : SIRegLoHi16<"src_pops_exiting_wave_id", 239>;
+}
----------------
jrtc27 wrote:
> This wasn't constant before
fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131962/new/

https://reviews.llvm.org/D131962