[PATCH] D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 07:37:43 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:966
 
+  LegalizeKind getTypeConversion(LLVMContext &Context, EVT VT) const;
   /// Return how we should legalize values of this type, either it is already
----------------
dfukalov wrote:
> RKSimon wrote:
> > doxygen comment / description?
> I Just moved the declaration from private to public section to allow access it from `BasicTTIImplBase<T>::getTypeLegalizationCost()`.
> There was no description in previous place. The function returns pair of values, which are actually mainly used by `getTypeAction()` (uses first element of pair) and `getTypeToTransformTo()` (uses second element). These interfaces have descriptions (related to first and second element of pair respectively.
> So, should I copy+combine these descriptions or move them? Or perhaps place references here or there (after move)?
Yeah, a copy + combine + tweak should be OK - we just need a summary of what is expected. Cheers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117723/new/

https://reviews.llvm.org/D117723



More information about the llvm-commits mailing list