[PATCH] D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo.

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:966
 
+  LegalizeKind getTypeConversion(LLVMContext &Context, EVT VT) const;
   /// Return how we should legalize values of this type, either it is already
----------------
RKSimon wrote:
> doxygen comment / description?
I Just moved the declaration from private to public section to allow access it from `BasicTTIImplBase<T>::getTypeLegalizationCost()`.
There was no description in previous place. The function returns pair of values, which are actually mainly used by `getTypeAction()` (uses first element of pair) and `getTypeToTransformTo()` (uses second element). These interfaces have descriptions (related to first and second element of pair respectively.
So, should I copy+combine these descriptions or move them? Or perhaps place references here or there (after move)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117723/new/

https://reviews.llvm.org/D117723