[PATCH] D131548: [AArch64]Remove svget/svset/svcreate from llvm

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 06:29:12 PDT 2022


sdesmalen added a comment.

Can you also add a test for fixed-width vectors?



================
Comment at: llvm/test/Transforms/InstCombine/sve-intrinsic-opts-tuple-extract.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S -passes=instcombine < %s | FileCheck %s
----------------
Please also remove `sve-` from the name and any references to aarch64/SVE, e.g.
* this test currently calls `@llvm.aarch64.sve.st4`
* this test currently uses `attributes #0 = { "target-features"="+sve" }`
* this test current has `target triple = "aarch64-unknown-linux-gnu"`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131548/new/

https://reviews.llvm.org/D131548



More information about the llvm-commits mailing list