[PATCH] D131548: [AArch64]Remove svget/svset/svcreate from llvm

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 06:27:05 PDT 2022


CarolineConcatto marked 2 inline comments as done.
CarolineConcatto added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2437
+
+    // (extract_vector (insert_vector InsertTuple, InsertValue, InsertIdx), ExtractIdx)
+    unsigned ExtractIdx = cast<ConstantInt>(Idx)->getZExtValue();
----------------
sdesmalen wrote:
> Should this combine happen before the combine above?
I was not sure if I should change the order between fixed and generic. But now it is changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131548/new/

https://reviews.llvm.org/D131548



More information about the llvm-commits mailing list