[PATCH] D131881: [BOLT][AArch64] Ignore functions with constant islands during ICF and VeneerElimination

Denis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 04:11:02 PDT 2022


treapster added inline comments.


================
Comment at: bolt/include/bolt/Core/BinaryFunction.h:2016
+  bool hasIslandsInfo() const {
+    return Islands && (hasConstantIsland() || !Islands->Dependency.empty());
+  }
----------------
yota9 wrote:
> What problem is solved here?
The problem was that previous implementation returned true when there was a single $x symbol at the beginning of a function. Now we only consider data or dependencies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131881/new/

https://reviews.llvm.org/D131881



More information about the llvm-commits mailing list