[PATCH] D131881: [BOLT][AArch64] Ignore functions with constant islands during ICF and VeneerElimination

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 04:08:40 PDT 2022


yota9 requested changes to this revision.
yota9 added inline comments.
This revision now requires changes to proceed.


================
Comment at: bolt/include/bolt/Core/BinaryFunction.h:2016
+  bool hasIslandsInfo() const {
+    return Islands && (hasConstantIsland() || !Islands->Dependency.empty());
+  }
----------------
What problem is solved here?


================
Comment at: bolt/test/AArch64/prevent-ci-folding.s:2
+// This test checks that functions containing Constant Islands are not folded even
+// if they have the same instructions
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131881/new/

https://reviews.llvm.org/D131881



More information about the llvm-commits mailing list