[PATCH] D131867: [AVR] Do not emit instructions invalid for attiny10

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 02:00:40 PDT 2022


benshi001 accepted this revision.
benshi001 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AVR/AVRRegisterInfo.cpp:210
+  int MaxOffset = 62;
+  if (STI.hasTinyEncoding()) {
+    MaxOffset = 0;
----------------
It seems better to be 

```
int MaxOffset = STI.hasTinyEncoding() ? 0 : 62;
```

And you can change to that when committing your patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131867/new/

https://reviews.llvm.org/D131867



More information about the llvm-commits mailing list