[PATCH] D130479: [ORC_RT][COFF] Initial platform support for COFF/x86_64.

[Lang Hames via Phabricator via llvm-commits]

lhames added inline comments.


================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink.cpp:1222-1223
 
+Expected<JITDylib *> Session::getOrLoadDynamicLibrary(StringRef LibName,
+                                                      StringRef LibPath) {
+  auto It = DynLibJDs.find(LibName.str());
----------------
lhames wrote:
> lhames wrote:
> > sunho wrote:
> > > lhames wrote:
> > > > Is there any reason to make a distinction between `LibName` and `LibPath` here? Could we just use the path as the name?
> > > It's separated because same DLL can exist in multiple include pathes. All the path stuffs is done to make sure we don't double import the same DLL.
> > Are DLLs identified by filename alone then? Or is there some other way to tell whether two DLLs represent the same logical library?
> Oh -- LibName here comes from `-
> Oh -- LibName here comes from `-

Disregard that -- it was a stale comment from an earlier pass on the review. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130479/new/

https://reviews.llvm.org/D130479