[PATCH] D128216: [X86] Add SimplifyMultipleUseDemandedBitsForTargetNode X86ISD::ANDNP handling

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 09:32:40 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:42160
+
+    // If all of the demanded bits are known 1 on one side, return the other.
+    // These bits cannot contribute to the result of the 'andn' in this
----------------
This comment was copy and pasted from ISD::AND and seems incorrect. It says "known 1" but we're checking Known.Zero. We're only doing it for the LHS so "one side" and "the other" should be more precise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128216/new/

https://reviews.llvm.org/D128216



More information about the llvm-commits mailing list