[PATCH] D131727: Enable -Wctad-maybe-unsupported in LLVM build

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added a comment.

In D131727#3717576 <https://reviews.llvm.org/D131727#3717576>, @MaskRay wrote:

> Adding the warning LGTM. The summary should state what `-Wctad-maybe-unsupported` is and how it is useful.
>
> I see that https://discourse.llvm.org/t/rfc-increasing-the-gcc-and-clang-requirements-to-support-c-17-in-llvm/59983 didn't discuss CTAD.

I explicitly mentioned it in that thread, and there was no opposition to it.  Nor have I seen any concerns about it in any other relevant thread.

> If there are mixed feelings, I think we should be conservative by doing this, and let folks propose CTAD to make convincing arguments not to use -Wctad-maybe-unsupported

I don't think there is any harm in requiring an explicit guide, and it shouldn't hinder the use of CTAD.  Do you know of any cases where such a guide cannot be added?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131727/new/

https://reviews.llvm.org/D131727