[PATCH] D131727: Enable -Wctad-maybe-unsupported in LLVM build
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 11 15:19:37 PDT 2022
dblaikie marked an inline comment as done.
dblaikie added a comment.
In D131727#3717576 <https://reviews.llvm.org/D131727#3717576>, @MaskRay wrote:
> Adding the warning LGTM. The summary should state what `-Wctad-maybe-unsupported` is and how it is useful.
Updated wording.
Mostly wasn't settling on the commit message until the substantive parts of the patch were worked out, like whether people agreed and what to do with libcxx.
================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:795
+
+ # Enable -Wstring-conversion to catch misuse of string literals.
+ add_flag_if_supported("-Wctad-maybe-unsupported" CTAD_MAYBE_UNSPPORTED_FLAG)
----------------
MaskRay wrote:
> typo in comment
ah, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131727/new/
https://reviews.llvm.org/D131727
More information about the llvm-commits
mailing list