[PATCH] D131503: [DAGCombine] Combine signext_inreg of extract-extend

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 05:58:27 PDT 2022


RKSimon accepted this revision.
RKSimon added a comment.

LGTM - cheers!



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6377
+    if (N1C->getAPIntValue().isMask(ScalarWidth) &&
+        (!LegalOperations || TLI.isOperationLegal(ISD::ZERO_EXTEND, ExtVT))) {
       //    (and (extract_subvector (zext|anyext|sext v) _) iN_mask)
----------------
Please commit this separately referencing the phab patch where it was added (D130782?)


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13169
+
+    if (ExtVTBits == Extendee->getValueType(0).getScalarSizeInBits() &&
+        (!LegalOperations ||
----------------
Extendee.getValueType()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131503/new/

https://reviews.llvm.org/D131503



More information about the llvm-commits mailing list