[PATCH] D131551: [RISCV] Add binary mask pattern for vector integer binary instructions.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 09:20:49 PDT 2022


craig.topper added a comment.

We've been discussing doing this as a post isel peephole or a DAG combine in D130442 <https://reviews.llvm.org/D130442>. That should have much less impact on the size of the generated isel table.

It might not be a good idea to do this fold without checking that the select is the only user of binary op. If it's not the only user you'll duplicate the binary op and there will be a masked and unmasked version. This can increase register pressure and use more execution resources.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131551/new/

https://reviews.llvm.org/D131551



More information about the llvm-commits mailing list