[PATCH] D131290: [llvm-objdump] Create name for fake sections

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D131290#3710905 <https://reviews.llvm.org/D131290#3710905>, @MaskRay wrote:

> Does GNU objdump use `load0`?
>
>   % objdump -h llvm/test/Object/Inputs/no-sections.elf-x86-64 
>   
>   llvm/test/Object/Inputs/no-sections.elf-x86-64:     file format elf64-x86-64
>   
>   Sections:
>   Idx Name          Size      VMA               LMA               File off  Algn
>
> I think `PT_LOAD#0` looks good to me, but I don't object to matching GNU objdump for the commonly used PT_LOAD.
> There is a small issue that we have to invent names for `PT_*` values, for values that GNU objdump doesn't hard code.
> This is probably an area whether 100% compatibility doesn't matter.

I'm not sure we need to worry about inventing names for other `PT_*` values at this time, because fake sections are only created for executable PT_LOAD, if I'm not mistaken. That being said, I agree that it's unlikely it matters whether this is 100% compatible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131290/new/

https://reviews.llvm.org/D131290