[PATCH] D131290: [llvm-objdump] Create name for fake sections

[Namhyung Kim via Phabricator via llvm-commits]

namhyung added inline comments.


================
Comment at: llvm/include/llvm/Object/ELF.h:185
   std::vector<Elf_Shdr> FakeSections;
+  std::vector<char> FakeSectionStrings;
 
----------------
MaskRay wrote:
> Use `SmallString<0> FakeSectionStrings`.
> 
> Prefer `SmallString` because `std::string` has a small string optimization which isn't useful for this case.
But I think it'd be better to use StringTableBuilder as @jhenderson said.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131290/new/

https://reviews.llvm.org/D131290