[PATCH] D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 17:42:04 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/IR/Mangler.cpp:248
+    OS << " -exclude-symbols:";
+
+    bool NeedQuotes = GV->hasName() && !canBeUnquotedInDirective(GV->getName());
----------------
Is it useful to encode several symbols joined by `,` with one `-exclude-symbols:`? Just to make the section content smaller.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130121/new/

https://reviews.llvm.org/D130121



More information about the llvm-commits mailing list