[PATCH] D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I follow COFF development passively. Representing hidden visibility with `-exclude-symbols:` in `.drectve` LGTM.
Due to the limitation of the format, this seems the best possible emulation.
The performance issue seems to mitigated by having a fast path following D78845 <https://reviews.llvm.org/D78845>.



================
Comment at: llvm/test/CodeGen/X86/mingw-hidden.ll:2
+; RUN: llc -mtriple i386-pc-win32 < %s \
+; RUN:    | FileCheck -check-prefix CHECK -check-prefix CHECK-MSVC %s
+; RUN: llc -mtriple i386-pc-mingw32 < %s \
----------------
Use `--check-prefixes`


================
Comment at: llvm/test/CodeGen/X86/mingw-hidden.ll:72
+; CHECK-MINGW: .section .drectve
+; CHECK-MINGW: .ascii " -exclude-symbols:f1"
+; CHECK-MINGW: .ascii " -exclude-symbols:f2"
----------------
-SAME


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130121/new/

https://reviews.llvm.org/D130121