[PATCH] D131329: [SDAG] Add `getCALLSEQ_END` overload taking `uint64_t`s
Sergei Barannikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 9 13:50:27 PDT 2022
barannikov88 added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:967
+ SDValue getCALLSEQ_END(SDValue Chain, uint64_t Size1, uint64_t Size2,
+ SDValue Glue, const SDLoc &DL) {
----------------
jrtc27 wrote:
> Size1/Size2 aren't great names; getCALLSEQ_START calls them InSize and OutSize which seems better to me.
The meaning of these values is target-dependent (see the comment near CALLSEQ_START/CALLSEQ_END nodes). Giving them any specific names would suggest the opposite. "InSize" and "OutSize" are not very meaningful names anyway (what is "in" and "out" here?).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131329/new/
https://reviews.llvm.org/D131329
More information about the llvm-commits
mailing list