[PATCH] D131329: [SDAG] Add `getCALLSEQ_END` overload taking `uint64_t`s

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 13:29:48 PDT 2022


jrtc27 added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:967
 
+  SDValue getCALLSEQ_END(SDValue Chain, uint64_t Size1, uint64_t Size2,
+                         SDValue Glue, const SDLoc &DL) {
----------------
Size1/Size2 aren't great names; getCALLSEQ_START calls them InSize and OutSize which seems better to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131329/new/

https://reviews.llvm.org/D131329



More information about the llvm-commits mailing list