[PATCH] D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper

[Anubhab Ghosh via Phabricator via llvm-commits]

argentite added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp:278
+
+  return Error::success();
+}
----------------
RKSimon wrote:
> @argentite Static analysis is complaining that this second return is dead code - is it or should the `return release()` be inside the if() ?
Yup that release should be inside the if body but we also can't hold the mutex while calling release. I reordered them here: https://reviews.llvm.org/D131510 .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128544/new/

https://reviews.llvm.org/D128544