[PATCH] D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 9 09:08:01 PDT 2022
RKSimon added inline comments.
================
Comment at: llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp:278
+
+ return Error::success();
+}
----------------
@argentite Static analysis is complaining that this second return is dead code - is it or should the `return release()` be inside the if() ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128544/new/
https://reviews.llvm.org/D128544
More information about the llvm-commits
mailing list