[lld] 09db7f5 - [lld/mac] Remove unusual "Fallthrough" comments

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 11:19:25 PDT 2022


Author: Nico Weber
Date: 2022-08-08T14:18:44-04:00
New Revision: 09db7f533174cdda4655d0114cd88bd22d336e31

URL: https://github.com/llvm/llvm-project/commit/09db7f533174cdda4655d0114cd88bd22d336e31
DIFF: https://github.com/llvm/llvm-project/commit/09db7f533174cdda4655d0114cd88bd22d336e31.diff

LOG: [lld/mac] Remove unusual "Fallthrough" comments

Normally we'd use LLVM_FALLTHROUGH, or now, [[fallthrough]].
But for case labels followed directly by other case labels, we
use neither.

No behavior change.

Added: 
    

Modified: 
    lld/MachO/InputFiles.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/InputFiles.cpp b/lld/MachO/InputFiles.cpp
index 8a414691ea6c9..1f1cf5aa00094 100644
--- a/lld/MachO/InputFiles.cpp
+++ b/lld/MachO/InputFiles.cpp
@@ -1961,10 +1961,10 @@ DylibFile::DylibFile(const InterfaceFile &interface, DylibFile *umbrella,
       continue;
 
     switch (symbol->getKind()) {
-    case SymbolKind::GlobalSymbol:               // Fallthrough
-    case SymbolKind::ObjectiveCClass:            // Fallthrough
-    case SymbolKind::ObjectiveCClassEHType:      // Fallthrough
-    case SymbolKind::ObjectiveCInstanceVariable: // Fallthrough
+    case SymbolKind::GlobalSymbol:
+    case SymbolKind::ObjectiveCClass:
+    case SymbolKind::ObjectiveCClassEHType:
+    case SymbolKind::ObjectiveCInstanceVariable:
       normalSymbols.push_back(symbol);
     }
   }


        


More information about the llvm-commits mailing list