[PATCH] D131309: [ELF] Add ability to get a symbol by name from the hash table section

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 added a comment.

In D131309#3706189 <https://reviews.llvm.org/D131309#3706189>, @JonChesterfield wrote:

> Could you call this function from the amdgpu plugin in the same patch? In particular the sketchy looking hashtable logic is likely to be a copy from there with modifications to fit the llvm libs and it'll be easier to review with that in the diff scope.
>
> Basically I can't remember the details of that lookup but remember writing it carefully at the time + it's been in use in that plugin for a year or so. I'd like to verify that the logic is unchanged by the move between files.

I'd prefer not to make this patch really messy with all the required changes in Libomptarget, I can make a new patch for that and put it on the stack for this one. Here's the relevant file if you'd rather look at what's in-source first. For the functionality I figured the runtime test I added was sufficient, though I could make it more complicated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131309/new/

https://reviews.llvm.org/D131309