[PATCH] D131309: [ELF] Add ability to get a symbol by name from the hash table section

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 04:40:26 PDT 2022


JonChesterfield added a comment.

Could you call this function from the amdgpu plugin in the same patch? In particular the sketchy looking hashtable logic is likely to be a copy from there with modifications to fit the llvm libs and it'll be easier to review with that in the diff scope.

Basically I can't remember the details of that lookup but remember writing it carefully at the time + it's been in use in that plugin for a year or so. I'd like to verify that the logic is unchanged by the move between files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131309/new/

https://reviews.llvm.org/D131309



More information about the llvm-commits mailing list