[PATCH] D130787: [lld][ELF] Rename SymbolTable::symbols() to SymbolTable::getSymbols(). NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 12:46:28 PDT 2022


MaskRay added a comment.

I feel that `symbols()` is a better name. I am not sure the consistency with other ports matters in this case. The data structures are so different. Using `symbols` for symtab and `getSymbols` for `InputFile` has another benefit that we can easily distinguish the two use cases (which are very different).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130787/new/

https://reviews.llvm.org/D130787



More information about the llvm-commits mailing list