[PATCH] D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 10:22:24 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/be-image-disasm.test:1
+# RUN: yaml2obj -DCONTENT=FA000002E59F100CE0800001E12FFF1E4802EB00308047703141592627182818 %s | llvm-objdump -d --triple=armv7r - | FileCheck %s
+# RUN: yaml2obj -DCONTENT=020000FA0C109FE5010080E01EFF2FE1024800EB803070473141592627182818 -DFLAG=,EF_ARM_BE8 %s | llvm-objdump -d --triple=armv7r - | FileCheck %s
----------------
You can place be-image-disasm.test and be-object-disasm.test in one file.

Grep `docnum` on existing tests.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/be-image-disasm.test:4
+
+# Test llvm-objdump disassembly of both kinds of AAELF32-compliant
+# big-endian AArch32 ELF image. By default, AArch32 ELF stores the
----------------
binary utility test directories use `## ` for non-RUN non-CHECK comments. They make comments stand out and they may be highlit with different styles in an editor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130902/new/

https://reviews.llvm.org/D130902



More information about the llvm-commits mailing list