[PATCH] D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham added a comment.

I didn't know about that previous patch at all, but off the top of my head, yes, I don't think it should be necessary at least for ELF files, because the combination of ELF header endianness and `EF_ARM_BE8` flag is enough to autodetect the right code endianness in all cases.

For other Arm object file formats, on the other hand, I can't say the same. I know nothing at all about big-endian support in Arm COFF, for example, including whether it has any BE support at all!

I wouldn't rule out the possibility that at some point an instance of MCDisassembler might need to have its code endianness manually set to the right state – but the facility provided in this commit can be reused for that, if and when the use case shows up, because all you have to do is to set the new `big-endian-instructions` subtarget feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130902/new/

https://reviews.llvm.org/D130902