[PATCH] D129745: Fix a stack overflow in ScalarEvolution.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 04:10:19 PDT 2022


fhahn added a comment.

In D129745#3702070 <https://reviews.llvm.org/D129745#3702070>, @jreiffers wrote:

> In D129745#3702054 <https://reviews.llvm.org/D129745#3702054>, @fhahn wrote:
>
>>> It might be good to adjust the commit message to be a bit more precise about the actual fix.
>>
>> It would have been good to improve the commit title....
>
> Sorry, missed that. Also, I don't know what improvement you had in mind. I find it pretty clear.

It's too generic, it should ideally be more clear about which stack overflow was fixed for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129745/new/

https://reviews.llvm.org/D129745



More information about the llvm-commits mailing list