[PATCH] D129745: Fix a stack overflow in ScalarEvolution.

Fri Aug 5 04:03:03 PDT 2022

jreiffers added a comment.

In D129745#3702054 <https://reviews.llvm.org/D129745#3702054>, @fhahn wrote:

>> It might be good to adjust the commit message to be a bit more precise about the actual fix.
>
> It would have been good to improve the commit title....

Sorry, missed that. Also, I don't know what improvement you had in mind. I find it pretty clear.

================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:7318
+        if (NewBO->Op && (NewBO->IsNSW || NewBO->IsNUW)) {
+          if (auto *I = dyn_cast<Instruction>(NewBO->Op);
+              I && programUndefinedIfPoison(I)) {
----------------
fhahn wrote:
> frasercrmck wrote:
> > Correct me if I'm wrong but we're not yet able to use C++17 features. This is causing a build bot failure: https://lab.llvm.org/buildbot#builders/77/builds/20381
> @jreiffers what's the status of this? Does the commit need reverting?
This was fixed in https://reviews.llvm.org/rG3e9e43b48eb7a6a9b317e4c32ba0ee672630842b.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129745/new/

https://reviews.llvm.org/D129745