[PATCH] D130075: [InstCombine] Try not to demand low order bits for Add

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 11:25:43 PDT 2022


spatel added a comment.

Sorry, I didn't notice the dependency between D130080 <https://reviews.llvm.org/D130080> and this one.

But I'm not seeing test coverage for the change here - the instcombine test is already folded without this patch:
https://alive2.llvm.org/ce/z/RtXYQq

I thought this patch would have an effect like this:
https://alive2.llvm.org/ce/z/XwHTxg
...but I don't see that change.

Should there be at least 2 tests (one each with `add` and `sub`) that are improved with this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130075/new/

https://reviews.llvm.org/D130075



More information about the llvm-commits mailing list