[PATCH] D131056: [ORC] Actually propagate memory unmapping errors on Windows

[Martin Storsjö via Phabricator via llvm-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG46bc1b5689e4: [ORC] Actually propagate memory unmapping errors on Windows (authored by mstorsjo).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131056/new/

https://reviews.llvm.org/D131056

Files:
  llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp


Index: llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp
===================================================================
--- llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp
+++ llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp
@@ -361,8 +361,8 @@
 #elif defined(_WIN32)
 
       if (!UnmapViewOfFile(Reservations[Base].LocalAddr))
-        joinErrors(std::move(Err),
-                   errorCodeToError(mapWindowsError(GetLastError())));
+        Err = joinErrors(std::move(Err),
+                         errorCodeToError(mapWindowsError(GetLastError())));
 
 #endif
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131056.449902.patch
Type: text/x-patch
Size: 565 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220804/679ce7ad/attachment.bin>