[PATCH] D129636: Fix a LSR debug invariance issue

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson added a comment.

In D129636#3696435 <https://reviews.llvm.org/D129636#3696435>, @markus wrote:

> Not sure if this ended up so well as it appears that `getExistingSCEV` was a private method and I am uncertain if we can or should make it public. Either way if we decide to go this route then we probably should add explicit tests for this part as well (i.e. to make sure that the forgetting of SCEV does not produce another invariance issue).

I similarly added a public method in rG116dc70 <https://reviews.llvm.org/rG116dc70cf3717eab495d80e4d78afe02fe6285ba> in an early SCEV-based salvaging patch. Understandably, I don't think it was envisaged at the time of implementation that SCEVs would be used for salvaging. I agree we should be careful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129636/new/

https://reviews.llvm.org/D129636