[PATCH] D129636: Fix a LSR debug invariance issue

Markus Lavin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 06:39:58 PDT 2022


markus updated this revision to Diff 449653.
markus added a comment.

Not sure if this ended up so well as it appears that `getExistingSCEV` was a private method and I am uncertain if we can or should make it public. Either way if we decide to go this route then we probably should add explicit tests for this part as well (i.e. to make sure that the forgetting of SCEV does not produce another invariance issue).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129636/new/

https://reviews.llvm.org/D129636

Files:
  llvm/include/llvm/Analysis/ScalarEvolution.h
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
  llvm/test/Transforms/LoopStrengthReduce/dbg-inv-0.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129636.449653.patch
Type: text/x-patch
Size: 5943 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220803/e0ff8842/attachment.bin>


More information about the llvm-commits mailing list