[PATCH] D117499: [CodeGen] Support extracting fixed-length vectors from illegal scalable vectors

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-extract-fixed-from-scalable-vector.ll:46
+
+define <4 x i16> @extract_v4i16_nxv32i16_8(<vscale x 32 x i16> %arg) {
+; CHECK-LABEL: extract_v4i16_nxv32i16_8:
----------------
Hmm, I just realised one or two test names are wrong, i.e. this function ends with _8 (for index 8), yet the actual IR has an extract from index 16.


================
Comment at: llvm/test/CodeGen/AArch64/sve-extract-fixed-from-scalable-vector.ll:281
+
+; Extracting an illegal fixed-length vector from an illegal subvector
+
----------------
I also realised this is a bogus comment because v2i32 is legal for NEON. Probably best to just remove the comment entirely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117499/new/

https://reviews.llvm.org/D117499