[PATCH] D127840: [MachinePipeliner] Fix Phi generation failure for large stages

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added a comment.

This is an interesting bug. The patch does fix a flaw with the current Phi generation by the pipeliner.  I think the approach here is a good one. It is a little difficult to understand the reason needed for the two different VRMaps though (much of the code in generatePhis is difficult to understand). But, the two maps do reduce some of the complexity in the code, which is good. I'll accept it once the test case comment is resolved. Thanks for fix the issue!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127840/new/

https://reviews.llvm.org/D127840