[PATCH] D127840: [MachinePipeliner] Fix Phi generation failure for large stages

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

Thanks for rebasing! I agree that the test failures are unrelated to your patch.
I'm not familiar with this pass, so I'm probably not the best person to review the code changes, but I think the test needs to be updated (see comment).



================
Comment at: llvm/test/CodeGen/PowerPC/sms-large-stages.mir:126
+  ; CHECK-NEXT: {{  $}}
+  ; CHECK-NEXT:   %29:f4rc = nofpexcept XSADDSP [[LFSU]], %21
+  ; CHECK-NEXT:   %30:vssrc = nofpexcept XSADDSP [[LFSU4]], [[LFSU4]]
----------------
I'm noticing a mix of FileCheck variables (e.g. LFSU) and plain MIR numbered variables (e.g. %29). Is this how the script generated the checks? In general, I think it's preferred to replace numbered variables with either FileCheck variables if they're relevant for the test, or `{{.*}}` otherwise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127840/new/

https://reviews.llvm.org/D127840