[PATCH] D130579: AMDGPU: Remove manual selection for atomic fadd
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 07:41:47 PDT 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12737
Subtarget->hasAtomicFaddNoRtnInsts()) {
- if (Subtarget->hasGFX940Insts())
+ if (Subtarget->hasGFX940Insts() || AMDGPU::isGFX11(*Subtarget))
return AtomicExpansionKind::None;
----------------
Petar.Avramovic wrote:
> I wanted to avoid lowering for gfx11, I am not sure if this is the correct place.
Should be based on a subtarget feature check, or at least the getGeneration() query on the subtarget. This also wouldn't belong in a change that's just supposed to stop using manual selection
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130579/new/
https://reviews.llvm.org/D130579
More information about the llvm-commits
mailing list