[PATCH] D130579: AMDGPU: Remove manual selection for atomic fadd
Petar Avramovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 05:55:56 PDT 2022
Petar.Avramovic added a comment.
I will to put tests in precommit but some will have to be excluded since they fail to select
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1344
Atomic.legalFor({{S32, GlobalPtr}});
+ if (ST.hasGFX940Insts())
+ Atomic.legalFor({{S32, FlatPtr}, {S64, FlatPtr}, {V2S16, FlatPtr}});
----------------
foad wrote:
> Apparently gfx90a has flat_atomic_add for f64 (but not f32 or v2f16). Are there any tests for that?
yes, there are a few but atomic gets lowered in ir. I will try to fix that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130579/new/
https://reviews.llvm.org/D130579
More information about the llvm-commits
mailing list