[PATCH] D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/be32-image-disasm.test:4
+# CHECK:     8000: fa000002      blx     0x8010
+# CHECK:     8004: e59f100c      ldr     r1, [pc, #12]
+# CHECK:     8008: e0800001      add     r0, r0, r1
----------------
Add `-NEXT` whenever appropriate


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/be32-image-disasm.test:45
+    Value:           0x8018
+...
----------------
delete `...`


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/be8-image-disasm.test:1
+# RUN: yaml2obj %s | llvm-objdump -d --triple=armv7r - | FileCheck %s
+
----------------
Do we need two files? Grep `yaml2obj .*-D` and use it to combine tests into one file.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/be8-image-disasm.test:3
+
+# CHECK:     8000: fa000002      blx     0x8010
+# CHECK:     8004: e59f100c      ldr     r1, [pc, #12]
----------------
Add -NEXT whenever appropriate


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/be8-image-disasm.test:45
+    Value:           0x8018
+...
----------------
delete `...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130902/new/

https://reviews.llvm.org/D130902