[PATCH] D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 00:19:27 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:683
 
+    llvm::support::endianness InstructionEndianness =
+        STI.checkFeatures("+big-endian-instructions") ? llvm::support::big
----------------
printInst is called for every instruction. Calling checkFeatures here may be too expensive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130902/new/

https://reviews.llvm.org/D130902



More information about the llvm-commits mailing list