[PATCH] D130824: [bolt] Fixed some typos

Gabriel Ravier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 30 11:13:42 PDT 2022


GabrielRavier added a comment.

Well, I assumed it was supposed to be [bolt] and not [BOLT] on the basis that the previous commit wrote it as [bolt] too but I'll change it, looking at the git log does indicate that [BOLT] is the more commonly used one



================
Comment at: bolt/lib/Passes/RetpolineInsertion.cpp:47
 
-cl::opt<RetpolineInsertion::AvailabilityOptions>
-R11Availability("r11-availability",
-  cl::desc("determine the availablity of r11 before indirect branches"),
-  cl::init(RetpolineInsertion::AvailabilityOptions::NEVER),
-  cl::values(
-    clEnumValN(RetpolineInsertion::AvailabilityOptions::NEVER,
-      "never", "r11 not available"),
-    clEnumValN(RetpolineInsertion::AvailabilityOptions::ALWAYS,
-      "always", "r11 avaialable before calls and jumps"),
-    clEnumValN(RetpolineInsertion::AvailabilityOptions::ABI,
-      "abi", "r11 avaialable before calls but not before jumps")),
-  cl::ZeroOrMore,
-  cl::cat(BoltCategory));
+cl::opt<RetpolineInsertion::AvailabilityOptions> R11Availability(
+    "r11-availability",
----------------
Amir wrote:
> I don't see any typos fixed here, can you please revert this hunk?
The fixed typo is "availablity" (which is spelled availability from what I can see), otherwise the formatting in general is caused by the `git clang-format` command that the LLVM documentation implies is required when making a patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130824/new/

https://reviews.llvm.org/D130824



More information about the llvm-commits mailing list