[PATCH] D130824: [bolt] Fixed some typos
Amir Ayupov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 30 11:00:25 PDT 2022
Amir added a comment.
@GabrielRavier: thank you for improving LLVM/BOLT codebase.
Please capitalize BOLT in the commit title and address one question inline. LGTM otherwise.
================
Comment at: bolt/lib/Passes/RetpolineInsertion.cpp:47
-cl::opt<RetpolineInsertion::AvailabilityOptions>
-R11Availability("r11-availability",
- cl::desc("determine the availablity of r11 before indirect branches"),
- cl::init(RetpolineInsertion::AvailabilityOptions::NEVER),
- cl::values(
- clEnumValN(RetpolineInsertion::AvailabilityOptions::NEVER,
- "never", "r11 not available"),
- clEnumValN(RetpolineInsertion::AvailabilityOptions::ALWAYS,
- "always", "r11 avaialable before calls and jumps"),
- clEnumValN(RetpolineInsertion::AvailabilityOptions::ABI,
- "abi", "r11 avaialable before calls but not before jumps")),
- cl::ZeroOrMore,
- cl::cat(BoltCategory));
+cl::opt<RetpolineInsertion::AvailabilityOptions> R11Availability(
+ "r11-availability",
----------------
I don't see any typos fixed here, can you please revert this hunk?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130824/new/
https://reviews.llvm.org/D130824
More information about the llvm-commits
mailing list