[PATCH] D130458: [llvm-objcopy] Support --{,de}compress-debug-sections for zstd

Fri Jul 29 13:06:39 PDT 2022

dblaikie added a comment.

In D130458#3688099 <https://reviews.llvm.org/D130458#3688099>, @MaskRay wrote:

> In D130458#3685479 <https://reviews.llvm.org/D130458#3685479>, @MaskRay wrote:
>
>> remove dependency on the API change (i.e. switch to a previous revision)
>
> Sorry, I made a mistake here. The patch did not depend on D130506 <https://reviews.llvm.org/D130506>. A second-to-last update added the dependency and made it subject to the D130506 <https://reviews.llvm.org/D130506>/D130516 <https://reviews.llvm.org/D130516> API design debate.

I think I follow that/understood that to be what you were saying originally. Though I think either way this patch is part of that design discussion - not designing the API and using a switch is a design choice in this space/one option to consider, but I'd like to consider them before going ahead with any.

> @dblaikie Realized I didn't make sure you were fine with this incremental direction - would you like me to revert while we settle on free function/classe based design first?

Yeah, I think it'd be good to revert this for now, thanks - this patch might be a good one to compare side-by-side with alternatives.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130458/new/

https://reviews.llvm.org/D130458