[PATCH] D125691: [DebugInfo] Add localDecls field to DISubprogram and DILexicalBlock (1/5)

Kristina Bessonova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 00:44:31 PDT 2022


krisb abandoned this revision.
krisb added a comment.

Tracking function-local entities per-scope is good from optimization point (we may remove DILexicalBlock if there are no instruction left in it), but it makes handling abstract trees in AsmPrinter difficult. 
We want to create an abstract scope if it is a parent scope for any of tracked nodes (this is true for local variables/labels as well as for other local entities). Since there are no easy ways to find which DILexicalBlocks belong to a particular subprogram, I'm not sure this approach is profitable.

So, I give up on this and switch the implementation to per-subprogram field. See D125693 <https://reviews.llvm.org/D125693> for details.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125691/new/

https://reviews.llvm.org/D125691



More information about the llvm-commits mailing list