[PATCH] D130787: [lld][ELF] Rename SymbolTable::symbols() to SymbolTable::getSymbols(). NFC

Fri Jul 29 10:47:57 PDT 2022

sbc100 added a comment.

In D130787#3687939 <https://reviews.llvm.org/D130787#3687939>, @MaskRay wrote:

> I feel that `symbols` is not a bad name. For two functions: `foo` and `getFoo`, if `foo` can trivially return the member variable (as in this case), I think it's totally fine.

I'm not really arguing that its a better name, just trying to be consistent with the other uses withing the ELF linker and other other backends (and the historical name).

The alternative would be create change for the wasm linker to make it consistent with the ELF one..   I can do that if you prefer, but then we would also probably want to update the other places where `getSymbols()` is used in the ELF/COFF and wasm backends already.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130787/new/

https://reviews.llvm.org/D130787