[PATCH] D130787: [lld][ELF] Rename SymbolTable::symbols() to SymbolTable::getSymbols(). NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 10:36:59 PDT 2022


MaskRay added a comment.

I feel that `symbols` is not a bad name. For two functions: `foo` and `getFoo`, if `foo` can trivially return the member variable (as in this case), I think it's totally fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130787/new/

https://reviews.llvm.org/D130787



More information about the llvm-commits mailing list