[PATCH] D130675: [RFC][DAG] Match select of constant equivalents in foldBinOpIntoSelect.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: llvm/test/CodeGen/X86/memcmp-more-load-pairs-x32.ll:165
+; X86-NEXT:    movl $-1, %eax
+; X86-NEXT:    cmovael %ecx, %eax
 ; X86-NEXT:    popl %esi
----------------
RKSimon wrote:
> deadalnix wrote:
> > @RKSimon Is this an improvement or a regression? Or it doesn't matter?
> Avoiding cmov for similar codesize is usually a win - they can't be predicted and have tight eflags dependencies
The codegen of llvm-libc `memcmp` and `bcmp` should directly benefit from it :-) Thx!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130675/new/

https://reviews.llvm.org/D130675